Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CNDB-12526 move PR checklist into PR comment #1541

Merged
merged 1 commit into from
Jan 31, 2025
Merged

CNDB-12526 move PR checklist into PR comment #1541

merged 1 commit into from
Jan 31, 2025

Conversation

k-rus
Copy link

@k-rus k-rus commented Jan 31, 2025 •
edited
Loading

What is the issue

Having checklist in the PR template creates an issue with copying PR description into squashed commit:

  • either commit messages are polluted with PR templates by default
  • or commit message contains only title by default.

What does this PR fix and why was it fixed

This PR moves checklist into separate comment, so both title and description of a PR can be copied into squashed commit message by default.

@k-rus k-rus changed the title CNDB-12526 move PR checklist into PR comment [WIP] CNDB-12526 move PR checklist into PR comment Jan 31, 2025
@k-rus k-rus marked this pull request as draft January 31, 2025 11:35
@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 31, 2025 •
edited by k-rus
Loading

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

@k-rus k-rus marked this pull request as ready for review January 31, 2025 11:38
@k-rus k-rus changed the title [WIP] CNDB-12526 move PR checklist into PR comment CNDB-12526 move PR checklist into PR comment Jan 31, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@cassci-bot
Copy link

✔️ Build ds-cassandra-pr-gate/PR-1541 approved by Butler

Approved by Butler
See build details here

jtgrabowski
jtgrabowski approved these changes Jan 31, 2025
View reviewed changes
Copy link

@jtgrabowski jtgrabowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@k-rus k-rus merged commit a074898 into main Jan 31, 2025
467 of 474 checks passed
@k-rus k-rus deleted the rf-cndb-12526-checklist-comment branch January 31, 2025 15:58
@k-rus k-rus mentioned this pull request Jan 31, 2025
Merged
k-rus added a commit that referenced this pull request Feb 1, 2025
@k-rus
CNDB-12526 remove PR checklist (#1542)
ea4506b 
PR checklist is already delivered in a comment in
#1541
Removing the checklist from the PR template, which was missed.

Closes riptano/cndb#12526
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtgrabowski jtgrabowski jtgrabowski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@k-rus @cassci-bot @jtgrabowski