HCD-63: Upgrade Netty to 4.1.117 and BoringSSL to 2.0.69 #1544
+17
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist before you submit for review
|
szymon-miezal
force-pushed
the
HCD-63
branch
2 times, most recently
from
acbda4f to
b683351
Compare
szymon-miezal
changed the title
szymon-miezal
changed the title
bereng
approved these changes
Feb 10, 2025
|
Approved. Perf tests reports show nothing out of the ordinary. The test failures Butler complains about are from previous SHA runs. The last remaining one fails in the same manner as al older run. I would be good to complete the checklist imo. |
The primary motivation for this change is a bug that manifests in loading the cipher list for inter-node connections, which is slightly wider than the configured list. This bug appears to be a consequence of how OpenSSL handles cipher loading. Changing it doesn't seem feasible. Netty introduced changes to mitigate this misbehavior: - netty/netty#13810 - netty/netty#13840 To take advantage of these fixes, we need to upgrade Netty to at least version 4.1.108. Upgrading Netty also necessitates bumping BoringSSL.
szymon-miezal
force-pushed
the
HCD-63
branch
from
b683351 to
cc3553c
Compare
|
After giving it a bit more thought I think it doesn't make much sense to upgrade to non-latest. I am going to bump it to |
szymon-miezal
changed the title
|
❌ Build ds-cassandra-pr-gate/PR-1544 rejected by Butler1 new test failure(s) in 6 builds Found 1 new test failures
Found 15 known test failures |
|
Update: I am rerunning fallout tests after bumping to 4.1.117. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The primary motivation for this change is a bug that manifests in loading
the cipher list for inter-node connections, which is slightly wider than the
configured list. This bug appears to be a consequence of how OpenSSL handles
cipher loading. Changing it doesn't seem feasible.
Netty introduced changes to mitigate this misbehavior:
To take advantage of these fixes, we need to upgrade Netty to at least
version 4.1.108. Upgrading Netty also necessitates bumping BoringSSL.
I have found some old CC tests in fallout that I decided to reuse to ensure the performance stays unchanged:
I have used the fallout perf tool to compare the results with
mainand they seem pretty comparable to me. Example chart:I am unsure whether there are other tests that exercise CC which could be reused.