CNDB-12739: Fix row filter ignoring distinct index and query analyzers

[adelapena]

Make RowFilter.Expression consider the two different analyzers that an index can have, one for write time and the other for read time.

[github-actions]

Checklist before you submit for review

• Make sure there is a PR in the CNDB project updating the Converged Cassandra version
• Use NoSpamLogger for log lines that may appear frequently in the logs
• Verify test results on Butler
• Test coverage for new/modified code is > 80%
• Proper code formatting
• Proper title for each commit staring with the project-issue number, like CNDB-1234
• Each commit has a meaningful description
• Each commit is not very long and contains related changes
• Renames, moves and reformatting are in distinct commits

[ekaterinadimitrova2]

I understand we care the most about the test case added at the moment. But I want to point out a few things for follow-up:

• test coverage pointed by sonar
• see what other cases tested in unit tests should be covered in distributed tests, too
  I have a single question, please test if we do not need actually to duplicate the buffer here - https://github.com/datastax/cassandra/pull/1548/files#diff-77d7c5f1289b354166e4f2c6fccc74198b556b8f93958e8548d971266692685dR684
• @michaeljmarshall 's comment about merging the distributed tests

While you check that I will verify also the other PR

[ekaterinadimitrova2]

Shouldn't this do the reset on a duplicate of value?

[adelapena]

Probably yes. I guess it's not failing because the caller doesn't do anything with the value after calling this, but it looks risky anyway, so I've added the duplication.

[ekaterinadimitrova2]

What you said makes sense to me. As we need to be very careful with this PR - @michaeljmarshall , third pair of eyes on this, please, if you have a moment?

[michaeljmarshall]

I agree that calling duplicate is the safe option here and unless we have a reason to believe it is a hotspot, we should just call duplicate for now.

[adelapena]

• test coverage pointed by sonar

Changing the signature of Operator#isSatisfiedBy makes a lot of already existing, mostly unrelated, poorly tested code visible to Sonar.

[michaeljmarshall]

LGTM

[michaeljmarshall]

This is unrelated to the PR, so should not block anything, but I wonder if we should add a method that checks if the column is analyzed instead of this getter, which allocates at least 2 objects per analyzer.

[ekaterinadimitrova2]

+1 on clean CI (still running), thank you

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
85.9% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[cassci-bot]

❌ Build ds-cassandra-pr-gate/PR-1548 rejected by Butler

---

1 new test failure(s) in 4 builds
See build details here

---

Found 1 new test failures

Test	Explanation	Branch history	Upstream history
o.a.c.u.b.BinLogTest.testTruncationReleasesLogS...	regression	🔴🔴🔴🔵	🔵🔵🔵🔵🔵🔵🔵

---

Found 7 known test failures