Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNDB-12406: Make CachedReplicaRows thresholds flexible to be set via … #1551

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

driftx
Copy link

@driftx driftx commented Feb 5, 2025

What is the issue

cached_replica_rows_[warn,fail]_threshold can only be set at in the yaml or via JMX.

What does this PR fix and why was it fixed

Adds system properties for these.

@driftx driftx self-assigned this Feb 5, 2025
Copy link

github-actions bot commented Feb 5, 2025

Checklist before you submit for review

  • Make sure there is a PR in the CNDB project updating the Converged Cassandra version
  • Use NoSpamLogger for log lines that may appear frequently in the logs
  • Verify test results on Butler
  • Test coverage for new/modified code is > 80%
  • Proper code formatting
  • Proper title for each commit staring with the project-issue number, like CNDB-1234
  • Each commit has a meaningful description
  • Each commit is not very long and contains related changes
  • Renames, moves and reformatting are in distinct commits

Copy link

sonarqubecloud bot commented Feb 5, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
60.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@cassci-bot
Copy link

✔️ Build ds-cassandra-pr-gate/PR-1551 approved by Butler


Approved by Butler
See build details here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants