chore: bump @start9labs/start-sdk to 1.5.1 - #6
Open
helix-nine wants to merge 1 commit into
Open
Conversation
Adds an `overrides` entry to force a single hoisted SDK copy across the sibling Start9 package dependencies (bitcoin-core-startos, bitcoind-knots, tor-startos), which still pin older SDK versions. Renames v29.3_2.ts → v29.3_3.ts and bumps the package revision to `#knotsrdts:29.3:3` per the rename-in-place convention for migration-free bumps. `npm update` was intentionally limited to the SDK bump: pulling the current tips of `bitcoin-core-startos#30.x` and `bitcoind-knots#next` removes the v28.3.5 / v29.3.5 / v30.2.5 Core version files this package (and Retropex's `next`) still import, breaking typecheck. Resolving that requires updating Core/Knots cross-version references in tandem with upstream Retropex — out of scope for a routine SDK bump. Typecheck (`npm run check`) and bundle (`npm run build`) both pass.
Owner
|
@Retropex can comment here, but my guess is that the official Knots package is what you want here, since BIP-110 is now merged into Knots v29.3.knots20260508. |
Collaborator
|
Correct, the latest version of Knots now include BIP 110. There is no need to maintain this package anymore. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@start9labs/start-sdkfrom1.0.0→1.5.1.overrides.@start9labs/start-sdktopackage.jsonso npm hoists a single SDK copy across the sibling Start9 deps (bitcoin-core-startos,bitcoind-knots,tor-startos) which still pin older SDK versions. Without this override, two SDK copies cause TS to infer generic input types asneverin helpers likesdk.action.createTask.startos/versions/v29.3_2.ts→v29.3_3.ts, bumps the package revision to#knotsrdts:29.3:3, and updates release notes (rename-in-place per the migration-free bump convention).Upstream check
v29.3.knots20260210+bip110-v0.4.1(78dfa44a). This is the latest BIP-110 tag indathonohm/bitcoin. Newer Bitcoin Knots tags (v29.3.knots20260507,v29.3.knots20260508) exist, but the BIP-110 patches haven't been rebased onto them yet — no submodule bump in this PR.bip110/knots-rebase-20261212describes asv29.2.knots20251110-62-…, i.e. older than the current pin, not a forward rebase.What
npm updatewas scoped tonpm updatewas intentionally limited to the SDK bump (lockfile reverted for git-pinned deps). Pulling the current tips ofbitcoin-core-startos#30.xandbitcoind-knots#nextwould remove thev28.3.5/v29.3.5/v30.2.5Core version files this package — andRetropex/knots-startos#nextitself — still import, breaking typecheck across the board:Resolving that requires updating Core/Knots cross-version references (
satisfies, themigrations.otherkeys, theversionGraph.otherarray) in tandem with an upstream Retropex bump that's outside the scope of a routine SDK refresh — flagging here so it can be picked up in normal development.Test plan
npm installsucceeds with the new SDK pinned at 1.5.1 and overridden across deps (npm ls @start9labs/start-sdkshows a single deduped copy).npm run check(tsc) passes.npm run build(ncc bundle) succeeds.makeproduces an.s9pk(the Makefile expects.git/HEAD/.git/indexdirectly in the worktree, which doesn't exist in agit worktreecheckout — pre-existing limitation of this repo'ss9pk.mk, not introduced by this PR; the hello-world-synced version frombitcoin-core-startosresolves it viagit rev-parse).