Conversation
…ose output; keep CLI diagnostic dumps on stdout; include themes as tracked files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces major improvements to theming and preferences management in the application. The most significant changes are the migration to global QSS-based theming for more consistent styling, support for command-line theme selection and stylesheet testing, and the addition of a new preferences storage system. Debug logging and diagnostic output have also been improved to better respect verbosity settings and provide clearer runtime information.
Theming and Styling Improvements:
AppRowandListView, and a root container was added to ensure stylesheet painting applies reliably. [1] [2] [3] [4] [5]--theme <name>) and stylesheet testing (--test-qss), enabling users to apply built-in or custom themes and verify QSS support. Theme and QSS application logic was updated to handle these flags and fallback to persisted styles when appropriate. [1] [2]Preferences Management:
Preferencesclass insrc/core/preferences.cppandsrc/core/preferences.h) for tracking pinned and hidden items, with support for loading and saving preferences to disk. [1] [2]CMakeLists.txt).Debugging and Diagnostics:
-v,-vvv) and provide clearer output, including per-run debug identifiers and improved launch diagnostics. [1] [2]std::coutfor CLI diagnostic dump mode inAppReader::DumpAndPrint, ensuring script compatibility and consistent output. [1] [2]Theme Manager Enhancements:
These changes collectively provide a more robust, customizable, and maintainable foundation for application theming and user preferences.