feat(config): add configurable timeout settings (v0.7.3) #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make all hardcoded timeouts configurable via the settings file to support users with slower systems or cold-start scenarios (e.g., when Ollama needs to reload models from memory). New TimeoutsConfig section supports: - embedding_request_ms: timeout for embedding API calls (default: 2 min) - daemon_start_ms: timeout waiting for daemon startup (default: 30 sec) - daemon_stop_ms: timeout waiting for daemon shutdown (default: 10 sec) - client_request_ms: CLI HTTP client timeout (default: 2 min) - api_request_ms: API middleware timeout (default: 2 min) - shutdown_ms: graceful shutdown timeout (default: 10 sec) Addresses feedback about timeout issues during initial indexing and cold starts. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TimeoutsConfigsection to settings with 6 configurable timeout valuesChanges
internal/config/config.go: Add TimeoutsConfig struct with helper methodsinternal/config/defaults.go: Add default timeout configurationinternal/embedder/provider.go: Pass timeout to embedder constructorsinternal/daemon/daemon.go: Use configurable embedding and shutdown timeoutsinternal/cli/client.go: Use configurable client request timeoutinternal/cli/start.go: Use configurable daemon start timeoutinternal/cli/stop.go: Use configurable daemon stop timeoutinternal/api/router.go: Use configurable API request timeoutConfiguration
Users can now configure timeouts in their
.pommel/config.yaml:Test plan
go build -tags fts5 ./...go test -tags fts5 ./...🤖 Generated with Claude Code