Repository navigation
StringParser: emit the captured small-tag text, not the literal string "$1" - #856
Open
ManasBagul23 wants to merge 1 commit into
Open
ManasBagul23 wants to merge 1 commit into
ManasBagul23 wants to merge 1 commit into
Conversation
…g "$1" postProcess replaces <small>...</small> tags using smallTagRegex.replaceAllIn(text, (m: Match) => ... "($1)" ...). This uses Regex.replaceAllIn Match => String overload, which uses the returned string verbatim (it is run through Matcher.quoteReplacement before being applied) -- unlike the separate String-replacement overload, it does not expand "$1" group references. So every non-empty <small>...</small> tag was replaced with the literal four characters ( $ 1 ), not its actual content. Confirmed with a direct java.util.regex reproduction of the exact appendReplacement/quoteReplacement mechanism Regex.replaceAllIn uses: the old code turns "<small>(extra info)</small>" into the literal text "($1)"; the fix produces "(extra info)" as intended. StringParser.parse backs the large majority of plain-text infobox property extraction across the whole framework, so this corrupts any such text containing a <small> tag with non-empty content. Fixed by concatenating the actual captured group instead of writing a literal $1 placeholder.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: emitting captured -tag text instead of the literal "$1". |
| Linked Issues check | |
Directly linked issue #855 requires StringParser.postProcess to preserve captured text from non-empty <small>...</small> tags instead of emitting literal ($1). The supplied change summary states… |
| Out of Scope Changes check | |
The supplied change summary contains one focused change in StringParser.postProcess: it replaces the literal ($1) result with captured <small> content. This change directly implements issue #855… |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
✨ Finishing Touches: 💡 1
-
🧪 Generate unit tests (beta)
-
- Create a new PR
🛠️ Fix failing CI checks: 💡
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
`postProcess` replaces `...` tags using `smallTagRegex.replaceAllIn(text, (m: Match) => ... "($1)" ...)`. This uses `Regex.replaceAllIn`'s `Match => String` overload, which uses the returned string verbatim (it is run through `Matcher.quoteReplacement` before being applied) -- unlike the separate String-replacement overload, it does not expand `$1` group references. So every non-empty `...` tag was replaced with the literal four characters `( $ 1 )`, not its actual content.
Confirmed with a direct `java.util.regex` reproduction of the exact `appendReplacement`/`quoteReplacement` mechanism `Regex.replaceAllIn` uses: the old code turns `"(extra info)"` into the literal text `"($1)"`; the fix produces `"(extra info)"` as intended.
`StringParser.parse` backs the large majority of plain-text infobox property extraction across the whole framework, so this corrupts any such text containing a `` tag with non-empty content.
Fix
Concatenate the actual captured group instead of writing a literal $1 placeholder.
Fixes #855
Summary by CodeRabbit
<small>tags is now preserved in parentheses when processed. Empty<small>content continues to be removed.