Repository navigation
ExtractorUtils: collectInternalLinksFromNode should recurse past a match too - #862
ManasBagul23 wants to merge 1 commit into
Conversation
…tch too Its three siblings in this file (collectParserFunctionsFromNode, collectTemplateParametersFromNode, collectTemplatesFromNodeTransitive) all continue recursing into a matched nodes own children after adding it, so a nested instance (e.g. a template inside a template) is still found. collectInternalLinksFromNode alone stopped at the first match, so a link nested inside another links own label/children (e.g. "[[A|see also [[B]]]]") only ever yielded A, never B. Made it recurse into the matched nodes children too, matching the established pattern of the other three collectors in this same file.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info
📝 Walkthrough
Merge Risk: ⚪ Minimal · up to
|
| Check name | Status | Explanation |
|---|---|---|
| Description Check |  |
Check skipped - CodeRabbit’s high-level summary is enabled. |
| Title check | |
The title clearly and concisely describes the main change: recursive traversal continues after a matching internal link is collected. |
| Docstring Coverage | |
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0… |
| Linked Issues check | |
Check skipped because no linked issues were found for this pull request. |
| Out of Scope Changes check | |
Check skipped because no linked issues were found for this pull request. |
Full details: Docstring Coverage
-
Explanation
No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
|
ExtractorUtils.collectInternalLinksFromNodeis the odd one out among its three siblings in thisfile (
collectParserFunctionsFromNode,collectTemplateParametersFromNode,collectTemplatesFromNodeTransitive): all three of those continue recursing into a matchednode's own children after collecting it, so a nested instance (e.g. a template inside a
template) is still found.
collectInternalLinksFromNodestopped at the first match instead, so alink nested inside another link's own label/children — for example
[[A|see also [[B]]]]— onlyever yielded
A, neverB.Fix: recurse into the matched node's children too, matching the established pattern of the
other three collectors in this same file.
Summary by CodeRabbit