add the -o omit_view_definitions=1 option to remove the view definitions from server side views
#14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 9, 2017 16:41
…ted schema classes for server views
|
+1 for this. MySQL includes the database name in the view definition, making the view undeployable to a database with a different name (which I do when running tests, for example.) Right now, I simply redefine the view later in the file, after the md5sum, and that works fine. But I'd like to be able to omit the dumped definition for clarity. |
ilmari
reviewed
Apr 12, 2020
| @@ -2626,8 +2631,8 @@ sub _setup_src_meta { | |||
| $self->_dbic_stmt($table_class, 'table', $table->dbic_name); | |||
|
|
|||
| # Must come after ->table | |||
| if ($is_view and my $view_def = $self->_view_definition($table)) { | |||
| $self->_dbic_stmt($table_class, 'result_source_instance->view_definition', $view_def); | |||
| if ( $is_view and my $view_def = $self->_view_definition( $table ) and not $self->omit_view_definitions ){ | |||
There was a problem hiding this comment.
There's no point in getting the view definition if we're not going to emit it, so please move the check before the ->_view_definition call. Also, please refrain from unrelated whitespace changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.