Add MariaDB.pm to DBI::Class::Schem::Loade::DBI #61
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The MariaDB package is needed when schema loader is using a newer MariaDB client because the mysql driver only supports MariaDB through version 4. Coincident with this proposed change a Maria.pm package appropriate for DBIx::Class::SQLMaker is being submitted
Add the MariaDB.pm package because the mysql driver does not support MariDB clients beyond version 4.
|
would you mind adding in a test that more or less copies the current mysql test? would be a big help b/c i don't know offhand by looking at this if it supports all the things that we support now |
|
@usna78 Thank you for your efforts on this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the traditional DBD::mysql driver only supports MariaDB clients through Version 4. Newer MariaDB clients like version 10 can not use the mysql driver. Using the DBD::MariaDB driver is the solution and the schema loader needs to recognize that driver. See https://blogs.perl.org/users/usna78/2024/05/mariadb-10-and-perl-dbixclassschemaloader.html