Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added multiple improvements and cleanups #1

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open
Changes from 1 commit
Commits
Show all changes
25 commits
Select commit Hold shift + click to select a range
cbc0957
improve description
nickyreinert Jan 23, 2024
e78092e
remove unused main function
nickyreinert Jan 23, 2024
e174d4c
refactoring
nickyreinert Jan 23, 2024
35822c5
remove len check, does not make sense here
nickyreinert Jan 23, 2024
927bf7a
removed type check, because it's not required, general cleanup
nickyreinert Jan 23, 2024
fe2f33d
refactoring
nickyreinert Jan 23, 2024
617ebbd
clean up: remove stats (failed, success) as it's not required
nickyreinert Jan 23, 2024
7e56854
refactoring cleanup
nickyreinert Jan 23, 2024
be332a9
clean up, refactroing
nickyreinert Jan 23, 2024
50f7bca
clean up
nickyreinert Jan 23, 2024
ee2984e
improved setup and first run routine
nickyreinert Jan 23, 2024
9c112ab
clean up inline cod
nickyreinert Jan 23, 2024
2711381
add chromedriver exec
nickyreinert Jan 23, 2024
a65eb84
improve output
nickyreinert Jan 23, 2024
7da22db
new feature: set cookies prior to request
nickyreinert Jan 23, 2024
c343026
add found requests to error output
nickyreinert Jan 23, 2024
fa0167a
add results folder if not exists
nickyreinert Jan 23, 2024
de198e3
add results folder if not exists
nickyreinert Jan 23, 2024
556e1f5
add example settings
nickyreinert Jan 23, 2024
b740f97
add results to gitignore
nickyreinert Jan 23, 2024
07cadf7
fix wrong join instruction
nickyreinert Jan 23, 2024
cb044cd
fix wrong argument order
nickyreinert Jan 23, 2024
939cd98
set default var mapping to "-"
nickyreinert Jan 23, 2024
5f42670
add openpyxl to req
nickyreinert Jan 23, 2024
7abf960
add openpyxl to req
nickyreinert Jan 23, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
add openpyxl to req
nickyreinert committed Jan 23, 2024
commit 7abf960f137f335635e25238dcb130b6fdec8069
2 changes: 1 addition & 1 deletion requirements.txt
Original file line number Diff line number Diff line change
@@ -2,4 +2,4 @@ selenium==4.1.0
selenium-wire==5.1.0
lxml==4.6.3
pandas==1.3.3
openpyxl=3.1.2
openpyxl==3.1.2