Skip to content

feat(go): skip tables in GetObjects that 403 #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
serramatutu merged 3 commits into from
Sep 17, 2026
Merged

feat(go): skip tables in GetObjects that 403 #17

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d7fcf68
feat(go): skip tables in GetObjects that 403 (#296)
lidavidm Sep 9, 2026
368b815
fix(go): skip 404'd tables in GetObjects
lidavidm Sep 17, 2026
5cbfa62
Fix logical error in error handling condition
lidavidm Sep 17, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 9 additions & 1 deletion go/connection.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ import (
"context"
"crypto/tls"
"encoding/json"
"errors"
"fmt"
"io"
"net/http"
Expand All @@ -43,6 +44,7 @@ import (
"github.com/apache/arrow-go/v18/arrow"
"golang.org/x/oauth2"
"golang.org/x/oauth2/google/externalaccount"
"google.golang.org/api/googleapi"
"google.golang.org/api/impersonate"
"google.golang.org/api/iterator"
"google.golang.org/api/option"
Expand Down Expand Up @@ -148,7 +150,6 @@ func (c *connectionImpl) GetDBSchemasForCatalog(ctx context.Context, catalog str
if schemaPattern.MatchString(ds.DatasetID) {
res = append(res, ds.DatasetID)
}

}

return res, nil
Expand Down Expand Up @@ -180,6 +181,13 @@ func (c *connectionImpl) GetTablesForDBSchema(ctx context.Context, catalog strin

md, err := table.Metadata(ctx, bigquery.WithMetadataView(bigquery.BasicMetadataView))
if err != nil {
if apiErr, ok := errors.AsType[*googleapi.Error](err); ok && (apiErr.Code == http.StatusForbidden || apiErr.Code == http.StatusNotFound) {
// "User does not have permission to access results of another user's job"
// No sense in erroring the entire list operation; just treat it as nonexistent

// Similarly a 404 probably just means a TOC/TOU error and we can proceed
continue
}
return nil, errToAdbcErr(adbc.StatusInternal, err, "get table metadata for %s.%s.%s", catalog, schema, table.TableID)
}

Expand Down
Loading