Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DBT model instrumentation #11268

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

DBT model instrumentation #11268

wants to merge 8 commits into from

Conversation

sfc-gh-vguttha
Copy link

Resolves #

Problem

Solution

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@sfc-gh-vguttha sfc-gh-vguttha requested a review from a team as a code owner February 3, 2025 11:02
@cla-bot cla-bot
Copy link

cla-bot bot commented Feb 3, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @sfc-gh-vguttha

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@github-actions github-actions bot added the community This PR is from a community member label Feb 3, 2025
@cla-bot cla-bot
Copy link

cla-bot bot commented Feb 17, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @sfc-gh-vguttha

@sfc-gh-vguttha sfc-gh-vguttha marked this pull request as draft February 17, 2025 08:36
@cla-bot cla-bot
Copy link

cla-bot bot commented Feb 17, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @sfc-gh-vguttha

sfc-gh-bdrutu
sfc-gh-bdrutu reviewed Feb 17, 2025
View reviewed changes
core/dbt/task/runnable.py Outdated
Comment on lines 232 to 233
if parent_context is None:
parent_context = context.get_current()
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No need? https://opentelemetry-python.readthedocs.io/en/latest/api/trace.html#opentelemetry.trace.Tracer.start_as_current_span

sfc-gh-bdrutu
sfc-gh-bdrutu reviewed Feb 17, 2025
View reviewed changes
Copy link

@sfc-gh-bdrutu sfc-gh-bdrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider to add tests, for that you can use the in memory SpanProcessor, make sure if you do that to use the SDK as a test dependency only.

sfc-gh-bdrutu
sfc-gh-bdrutu reviewed Feb 17, 2025
View reviewed changes
core/dbt/task/runnable.py
@@ -222,14 +226,32 @@ def get_runner(self, node) -> BaseRunner:

return cls(self.config, adapter, node, run_count, num_nodes)

def call_runner(self, runner: BaseRunner) -> RunResult:
with log_contextvars(node_info=runner.node.node_info):
def call_runner(self, runner: BaseRunner, parent_context=None) -> RunResult:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why passing the context?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because contextvars seem not be propagated automatically for thread pools. Hence I had to do this manually.

@cla-bot cla-bot
Copy link

cla-bot bot commented Feb 18, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @sfc-gh-vguttha

@cla-bot cla-bot
Copy link

cla-bot bot commented Feb 18, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @sfc-gh-vguttha

sfc-gh-vguttha
sfc-gh-vguttha commented Feb 18, 2025
View reviewed changes
dev-requirements.txt
Comment on lines +1 to +5
git+https://github.com/sfc-gh-vguttha/dbt-adapters.git@vguttha-add-telemetry#subdirectory=dbt-adapters
git+https://github.com/dbt-labs/dbt-adapters.git@main#subdirectory=dbt-tests-adapter
git+https://github.com/dbt-labs/dbt-common.git@main
git+https://github.com/dbt-labs/dbt-adapters.git@main#subdirectory=dbt-postgres
git+https://github.com/sfc-gh-vguttha/dbt-adapters.git@vguttha-add-telemetry#subdirectory=dbt-snowflake
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: will revert these changes once I am fully complete with my testing.

@cla-bot cla-bot
Copy link

cla-bot bot commented Feb 20, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @sfc-gh-vguttha

@cla-bot cla-bot
Copy link

cla-bot bot commented Feb 20, 2025

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, please reach out through a comment on this PR.

CLA has not been signed by users: @sfc-gh-vguttha

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-bdrutu sfc-gh-bdrutu Awaiting requested review from sfc-gh-bdrutu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
community This PR is from a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sfc-gh-vguttha @sfc-gh-bdrutu