Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support custom granularity in linkable spec resolution #1415

Merged
merged 4 commits into from
Sep 24, 2024
Merged

Support custom granularity in linkable spec resolution #1415

merged 4 commits into from
Sep 24, 2024

Commits on Sep 24, 2024

  1. Handle cumulative metric restrictions properly in linkable spec resol… 

    …ution

Cumulative metrics CAN be queried with non-default granularity now, so
remove that restriction. This was not an issue in actual queries because
 that logic was only hit when querying metadata, but this old logic
could result in a bug when listing dimensions for a cumulative metric.
Instead, restrict cumulative metrics from being used with date part,
which matches existing query behavior. This required adding a DATE_PART
LinkableElementProperty and updating LinkableDimensions accordingly.
    @courtneyholcomb
    courtneyholcomb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    157d93f View commit details
    Browse the repository at this point in the history

  2. Support custom granularities for metric_time resolution 

    Also updates related date part properties.
    @courtneyholcomb
    courtneyholcomb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    86b0e73 View commit details
    Browse the repository at this point in the history

  3. Support custom granularity in group by resolution for more metric types 

    This logic is only hit for certain types of metrics (like cumulative and
 derived metrics) so I didn't catch it until adding tests for those
metric types.
    @courtneyholcomb
    courtneyholcomb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    7cf6be7 View commit details
    Browse the repository at this point in the history

  4. Grammar

    @courtneyholcomb
    courtneyholcomb committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    8044a40 View commit details
    Browse the repository at this point in the history