Line detection PR #2 follow-up. #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* added sorting for fast clusterization
much better lines identification
* fixed line count
* better noise reduction (i hope)
* shred-dependent line length
… Clean up the code.
unshred/features/lines.py
Outdated
Owner
There was a problem hiding this comment.
Will it help to tune it if I provide you some manually classified shreds? If yes — please let me know what kind of info do you need.
Contributor
Author
There was a problem hiding this comment.
Not sure how classified data would help here. Will think about it.
Owner
There was a problem hiding this comment.
If we can count f1 score for each combination of input params on a known dataset then we can adjust params to achieve the best score possible.
Contributor
Author
There was a problem hiding this comment.
I'm not sure about effort/benefit of this. Might make sense to just leave these params loose and add additional posterior filtering.
…, TODOs. AUTHORS file.
Contributor
Author
|
Now compatible with master. |
Contributor
Author
|
PTAL. Line angle estimation added. |
dchaplinsky
added a commit
that referenced
this pull request
Nov 2, 2014
Line detection PR #2 follow-up.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes #2 rebased on top of current HEAD + a commit that cleans up the code and adds an improved adaptive thresholding routine.