Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat add generate segmentation from dataset #153

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

feat add generate segmentation from dataset #153

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
572cc04
feat(segmentation): add function to generate segmentation in cornerst…
helghast79 Nov 15, 2020
567931c
refactor function signature with more meaningfull name; expose functi…
helghast79 Nov 16, 2020
f9444d9
_meta property added automatically for every dataset if not defined o…
helghast79 Nov 17, 2020
1893686
add _meta default value in derived dataset constructor
helghast79 Nov 20, 2020
9d1773c
Merge branch 'master' into Segmentation-from-dataset
helghast79 Sep 6, 2021
67d9750
Merge branch 'master' into Segmentation-from-dataset
helghast79 Nov 2, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/adapters/Cornerstone/Segmentation.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -119,14 +119,14 @@ function fillSegmentation(
* @returns {Blob} description
*/
function generateSegmentationFromDatasets(
dataset,
datasets,
inputLabelmaps3D,
options = { includeSliceSpacing: true },
cornerstoneToolsVersion = 4
) {
if (cornerstoneToolsVersion === 4) {
return Segmentation_4X.generateSegmentationFromDatasets(
dataset,
datasets,
inputLabelmaps3D,
options
);
Expand Down
3 changes: 2 additions & 1 deletion src/adapters/Cornerstone/Segmentation_4X.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,8 @@ function generateSegmentationFromDatasets(
inputLabelmaps3D,
userOptions = {}
) {
//on multiframe images, datasets array contains only 1 element but should work as well
//make sure _meta property is present in every element of datasets with at least an empty array
datasets = datasets.map(ds => ({ ...ds, _meta: ds._meta || [] }));
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi - thanks for this, I'm trying to get my head back into the details.

Wouldn't we get the same effect more generally if this line where changed to:

_meta: this.referencedDataset._meta || []

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Pieper,

Yes, much better. Thanks

const multiframe = Normalizer.normalizeToDataset(datasets);
const segmentation = new SegmentationDerivation([multiframe], userOptions);
return fillSegmentation(segmentation, inputLabelmaps3D, userOptions);
Expand Down