Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: images with color pallet lut not displaying properly #251

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: images with color pallet lut not displaying properly #251

wants to merge 1 commit into from

Conversation

ladeirarodolfo
Copy link
Contributor

Includes:

  • When naturilazing dataset prevent adding accessors to TypedArray/ArrayBuffer types

wayfarer3130
wayfarer3130 reviewed Mar 7, 2022
View reviewed changes
src/DicomMetaDictionary.js
@@ -149,7 +151,9 @@ class DicomMetaDictionary {
if (
sqZero &&
typeof sqZero === "object" &&
!sqZero.length
!sqZero.length &&
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just use Array.isArray to check if the value is an array.

@pieper pieper mentioned this pull request Mar 7, 2022
Open
@wayfarer3130
Copy link
Contributor

Please just use Array.isArray, drop the two extra files, and add a unit test.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wayfarer3130 wayfarer3130 wayfarer3130 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ladeirarodolfo @wayfarer3130