[pull] main from GoogleCloudPlatform:main#20
Merged
Conversation
* feat: create a lint action * feat: add lint-changed.sh shell script * fix: Update lint-changed.sh * fix: add license header to lint-changed.sh * fix: minor update to GitHub action * fix: remove checking for pushes against main. we never push to main. * fix: update based on never pushing to main. * fix: address action scanning issue (maybe) * feat: add a failing test fixture for linting * feat: add a passing test python file for linting * fix: address header issues * fix: address header issues * fix: create updated noxfile template so that only targeted files are linted * fix: use customized noxfile template * fix: address on lint passing test Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com> * fix: address some of the noisy logging in the output to the action * chore: remove failing lint file for now .internal/tests/fixtures/test_fail.py * fix: no quiet mode :( * fix: address linting issues with lib and readd comment --------- Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
* fix: remove kokoro as required for running * fix: going ahead and removing * fix: Update PULL_REQUEST_TEMPLATE.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )
Summary by cubic
Introduce a GitHub Actions Lint workflow that only checks changed Python files with
noxsessions (blackandflake8) to reduce noise and replace Kokoro lint checks. Also updates the PR template and repository settings to align with the new flow.New Features
Lintworkflow for PRs (Python 3.10)..pyfiles via.github/scripts/lint-changed.sh.noxfile-lint.pywithnoxsessions:blackenandlint(flake8), avoiding repo-wide linting..internal/tests/fixtures/.Migration
Lintstatus; Kokoro lint/test contexts removed.nox -s blacken -- <files>andnox -s lint -- <files>.Written for commit c0076a1. Summary will update on new commits.