Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -2,3 +2,4 @@ Flask==3.1.3; python_version >= '3.9'
google-cloud-datastore==2.15.1
google-auth==2.17.3
requests==2.34.2; python_version >= '3.10'
urllib3>=2.2.2 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In application dependency files (like requirements.txt for Google App Engine), it is best practice to pin dependencies to exact versions using == instead of >=. This ensures reproducible builds and prevents unexpected deployment failures if a newer version of the library is released with breaking changes.

urllib3==2.2.2 # not directly required, pinned by Snyk to avoid a vulnerability

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2: urllib3 is not actually pinned: >=2.2.2 allows unbounded future versions, making installs non-deterministic and undermining the security fix intent.

Prompt for AI agents
Check if this issue is valid β€” if so, understand the root cause and fix it. At appengine/standard_python3/building-an-app/building-an-app-4/requirements.txt, line 5:

<comment>`urllib3` is not actually pinned: `>=2.2.2` allows unbounded future versions, making installs non-deterministic and undermining the security fix intent.</comment>

<file context>
@@ -2,3 +2,4 @@ Flask==3.1.3; python_version >= '3.9'
 google-cloud-datastore==2.15.1
 google-auth==2.17.3
 requests==2.34.2; python_version >= '3.10'
+urllib3>=2.2.2 # not directly required, pinned by Snyk to avoid a vulnerability
</file context>
Suggested change
urllib3>=2.2.2 # not directly required, pinned by Snyk to avoid a vulnerability
urllib3==2.2.2 # not directly required, pinned by Snyk to avoid a vulnerability