Conversation
deborahgu
reviewed
Feb 16, 2026
soundcork/devices.py
Outdated
| return bose_devices | ||
|
|
||
|
|
||
| def get_device_by_id(device_id: str) -> upnpclient.upnp.Device: |
Owner
There was a problem hiding this comment.
since you just pass in the no-device ID case, this should return an Optional.
deborahgu
reviewed
Feb 16, 2026
soundcork/main.py
Outdated
| "/marge/streaming/account/{account}/device/", | ||
| response_class=BoseXMLResponse, | ||
| tags=["marge"], | ||
| status_code=201, |
Owner
There was a problem hiding this comment.
Suggested change
| status_code=201, | |
| status_code=HTTPStatus.CREATED, |
deborahgu
reviewed
Feb 16, 2026
soundcork/main.py
Outdated
Comment on lines
+323
to
+326
| response.headers["Credentials"] = f"{request.headers.get('authorization')}" | ||
| response.headers["location"] = ( | ||
| f"{settings.base_url}/marge/account/{account}/device/{device_id}" | ||
| ) |
Owner
There was a problem hiding this comment.
Suggested change
| response.headers["Credentials"] = f"{request.headers.get('authorization')}" | |
| response.headers["location"] = ( | |
| f"{settings.base_url}/marge/account/{account}/device/{device_id}" | |
| ) |
you thought this was unecessary?
deborahgu
reviewed
Feb 16, 2026
soundcork/main.py
Outdated
| f"{settings.base_url}/marge/account/{account}/device/{device}" | ||
| ) | ||
| response.body = "" | ||
| response.status_code = 200 |
Owner
There was a problem hiding this comment.
Suggested change
| response.status_code = 200 | |
| response.status_code = HTTPStatus.CREATED |
deborahgu
approved these changes
Feb 16, 2026
Owner
deborahgu
left a comment
deborahgu
left a comment
There was a problem hiding this comment.
approved but minor changes requested.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #54