fix: preserve 'pattern' in antigravity tool schema translation (#1368)#1896
Open
mustafabozkaya wants to merge 4 commits into
Open
fix: preserve 'pattern' in antigravity tool schema translation (#1368)#1896mustafabozkaya wants to merge 4 commits into
mustafabozkaya wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where the
patternproperty and itsrequiredconstraint were being stripped fromglobandgreptool schemas when using the antigravity provider.Problem
The
cleanJSONSchemaForAntigravityfunction ingeminiHelper.jswas using a list of unsupported keywords that includedpattern. This caused the property to be removed from the translated schema, leading to errors when models tried to call these tools without the requiredpatternargument.Solution
"pattern"from theUNSUPPORTED_SCHEMA_CONSTRAINTSarray inopen-sse/translator/helpers/geminiHelper.js.tests/unit/gemini-helper-schema.test.jsto verify thatpatternandrequiredare correctly preserved.This fix ensures that tool schemas are correctly translated for the antigravity provider without losing essential properties.
Fixes #1368