feat(cli): add self-update command#23
Open
Shengming Liang (LiangShengming) wants to merge 4 commits into
Open
Conversation
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
What:
Add a custom
dedalus updatecommand with--check, install-method detection, and update dispatch for Homebrew cask, macOS/Linux install-script installs, and Windows installer instructions. The install script now writes a.dedalus-cli-installmarker so custom install directories remain updateable without requiring users to re-exportDEDALUS_INSTALL_DIR.Why:
Users need an explicit CLI update path that respects how the binary was installed. Custom install dirs previously depended on ambient shell state, which made updates fragile once the original install command was gone from the environment.
Test Plan
bash -n scripts/install.shgo test -run 'Test(Update|Latest)' ./pkg/cmdgo build ./..../scripts/lint./scripts/testRepro / Showcase
N/A. CLI update behavior is covered by unit tests with local HTTP servers and stubbed command runners;
dedalus update --checkexercises release discovery without installing.Tests Added
Unit tests
Integration tests
E2E tests
N/A (no new code paths)
Repository README:
README.md @ b3ea11fdocumentsdedalus updateanddedalus update --check.Risk areas:
latestVersionrelies on GitHub's/releases/latestredirect and parses the/tag/location.~/.local/binpath, a durable.dedalus-cli-installmarker, or the legacyDEDALUS_INSTALL_DIRenvironment hint.dedalus.exeprocess.