feat(cli): prompt for updates on startup#26
Open
Shengming Liang (LiangShengming) wants to merge 1 commit into
Open
feat(cli): prompt for updates on startup#26Shengming Liang (LiangShengming) wants to merge 1 commit into
Shengming Liang (LiangShengming) wants to merge 1 commit into
Conversation
c9d3c82 to
6c77e26
Compare
Collaborator
Author
|
End to end evidence: run 28068838181 passed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
Summary
What:
Add a startup update prompt for interactive Dedalus CLI launches. The prompt uses a cached latest-version check, skips noninteractive/CI/help/completion/root
updateflows, and delegates accepted updates to the existingdedalus updateimplementation.Why:
Users should not have to remember to run
dedalus update --checkmanually. The goal is to keep lightweight latest-version state on disk, prompt only when there is a newer version, and route the accepted update through the installer-aware update path.Test Plan
git diff --checkgo test -run 'Test(StartupUpdate|RootCommandArg|IsNewerVersion|Update|Latest)' ./pkg/cmdgo build ./..../scripts/lint./scripts/testRepro / Showcase
When an interactive launch has a cached or freshly fetched newer version, the CLI prints:
Pressing Enter runs
dedalus updateand exits after the update attempt. Typingncontinues to the original command. Noninteractive launches, CI, help/version commands, completion generation, anddedalus updateitself skip the startup prompt.Tests Added
Risk areas:
YesandNot now