Increase test coverage #497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
🔒 Could not start CI tests due to missing safe PR label. Please contact a DEDIS maintainer. |
matteosz
force-pushed
the
matt-increase-test-coverage
branch
from
5ee4043
to
f7ab373
Compare
AnomalRoil
approved these changes
Feb 15, 2024
matteosz
force-pushed
the
matt-increase-test-coverage
branch
from
f7ab373
to
5e18d48
Compare
AnomalRoil
previously approved these changes
Feb 19, 2024
pierluca
reviewed
Feb 25, 2024
util/encoding/encoding_test.go
Outdated
| return 0, nil | ||
| } | ||
|
|
||
| func TestReadHexPointError(t *testing.T) { |
There was a problem hiding this comment.
I'm going to be annoying on a point that's not common in this codebase, that is a bit of a pet peeve of mine, but which I think is important nonetheless:
This test contains 3 different test cases. When possible, try to have independent unit tests.
- This way, when the test fails, it tells you directly that it's the "reader fails" that fails, you don't have to look up which line this failed at.
- Furthermore, if the 3rd test case passes, you won't be able to tell (from the test results) if everything's grouped in a single test.
- Finally, having separate tests makes them more (trivially) independent of one another, and potentially parallelizable (not that it matters here)
matteosz
force-pushed
the
matt-increase-test-coverage
branch
from
5e18d48
to
38b49c6
Compare
pierluca
approved these changes
Mar 11, 2024
|
AnomalRoil
approved these changes
Mar 13, 2024
K1li4nL
pushed a commit
that referenced
this pull request
May 16, 2024
of util/encoding and util/encryption
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR increase the test coverage for the modules util/encoding and util/encryption