Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable linter in the CI #498

Closed
wants to merge 49 commits into from
Closed

Enable linter in the CI #498

wants to merge 49 commits into from

Conversation

K1li4nL
Copy link
Contributor

@K1li4nL K1li4nL commented Feb 16, 2024 •
edited
Loading

Golanci-lint has been added and most of the errors it found were fixed. (TODO and "deprecated" warnings were disabled)

@CLAassistant
Copy link

CLAassistant commented Feb 16, 2024 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@K1li4nL K1li4nL force-pushed the kilian-fix-ci-linter branch 3 times, most recently from d998d1f to 4aff994 Compare February 16, 2024 13:30
ineiti
ineiti reviewed Feb 19, 2024
View reviewed changes
Makefile Outdated Show resolved Hide resolved
@K1li4nL K1li4nL force-pushed the kilian-fix-ci-linter branch 12 times, most recently from 8d9d29c to 2be4796 Compare February 27, 2024 07:02
@K1li4nL K1li4nL marked this pull request as ready for review February 27, 2024 16:17
@K1li4nL K1li4nL closed this Feb 28, 2024
@K1li4nL K1li4nL reopened this Feb 28, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Mar 21, 2024

Quality Gate Passed Quality Gate passed

Issues
13 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.1% Coverage on New Code
5.0% Duplication on New Code

See analysis details on SonarCloud

@K1li4nL K1li4nL marked this pull request as draft April 2, 2024 11:18
@AnomalRoil AnomalRoil changed the base branch from master to drandmerge May 6, 2024 11:38
@K1li4nL K1li4nL self-assigned this May 23, 2024
K1li4nL added 26 commits May 24, 2024 11:28
@K1li4nL
Fix lint issues package curve25519
e58a5ff
@K1li4nL
Fix lint issues package shuffle
a69ac4c
@K1li4nL
Fix lint issues package dleq
da38859
@K1li4nL
Fix lint issues package share
b82af93
@K1li4nL
Fix lint issues package curve25519
9827768
@K1li4nL
Fix lint issues package anon
b1504e1
@K1li4nL
Fix lint issues package cosi
c1b4c40
@K1li4nL
Fix lint issues package ecies
dfb7d27
@K1li4nL
Fix lint issues dkg-rabin
891fbf0
@K1li4nL
Fix most lint issues package proof
5daa04b
@K1li4nL
Fix most lint issues package nist
be595d3
@K1li4nL
Fix lint issues sign
11c203b
@K1li4nL
Fix most lint issues share
440649d
@K1li4nL
Fix lint issues share
5149a1f
@K1li4nL
Reduce cogn. complexity
d551b65
@K1li4nL
Fix linter issues package edwards25519
755961d
@K1li4nL
relax golangci rules
225d36c
@K1li4nL
Fix last linter error in group
4db0c56
@K1li4nL
More linter fix
ee2f9c7
@K1li4nL
Rename unused parameters
f05993e
@K1li4nL
Setup golangci action
f9fa357
@K1li4nL
Divide large test
1f7b472
@K1li4nL
Fix new lint error shuffle
f5fcf0e
@K1li4nL
Fix lint error encoding
67df27b
@K1li4nL
Make initBasePoint() a method of curve25519
798e66a
@K1li4nL
Fix forgotten conflict
0adfea0
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
42.0% Duplication on New Code (required ≤ 10%)

See analysis details on SonarCloud

@K1li4nL K1li4nL closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ineiti ineiti ineiti left review comments

@AnomalRoil AnomalRoil AnomalRoil left review comments

Assignees

@K1li4nL K1li4nL

Labels
safe PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@K1li4nL @CLAassistant @ineiti @AnomalRoil