Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1784 Clear the previous PoP tokens before adding new ones #1786

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

arnauds5
Copy link
Collaborator

fixes #1784
When a valid lao#close is received, the attendees map in the lao is replace by an empty one, before the new keys are added.

@arnauds5 arnauds5 added be1-go bug-fix Fixes a bug labels Mar 20, 2024
@arnauds5 arnauds5 self-assigned this Mar 20, 2024
@arnauds5 arnauds5 requested a review from a team as a code owner March 20, 2024 19:44
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
MariemBaccari
🥇
5
▀▀
1d 15h 8m
1
matteosz
🥈
4
4d 19h 33m
11
▀▀▀▀
Tyratox
🥉
3
6d 19h 13m
1
quadcopterman
3
1d 2h 12m
0
pierluca
2
1d 3h 52m
0
4xiom5
2
4d 20h 10m
0
sgueissa
2
4d 21h 28m
8
▀▀▀
K1li4nL
2
13d 21h 43m
▀▀
5
▀▀
emonnin-epfl
2
7h 27m
1
arnauds5
1
6h 55m
0
osm-alt
1
5h 52m
0
ljankoschek
1
20h 9m
0
onsriahi14
1
20d 14h 22m
▀▀▀
0
Kaz-ookid
1
4d 10h 8m
0
⚡️ Pull request stats

Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 20, 2024

Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Mar 20, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Contributor

@1florentin 1florentin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Contributor

@MariemBaccari MariemBaccari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arnauds5 arnauds5 merged commit 32002f3 into master Mar 27, 2024
19 checks passed
@arnauds5 arnauds5 deleted the work-be1-arnauds5-clear-old-poptokens branch March 27, 2024 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] PoP Tokens are always valid on be1-go
3 participants