Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work protocol fix rumor message type #1811

Merged
merged 2 commits into from
Apr 16, 2024

Conversation

DanielTavaresA
Copy link
Collaborator

Small improvement to the rumor jsonRPC Schema. Before we used a Array[JsObject] to emulate a Map. But this behavior can be directly done having only a JsObject therefore we make the change.

@DanielTavaresA DanielTavaresA requested a review from a team as a code owner April 16, 2024 08:02
Copy link

Pull reviewers stats

Stats of the last 30 days for popstellar:

User Total reviews Time to review Total comments
K1li4nL
🥇
4
▀▀
8d 2h 16m
14
▀▀▀
matteosz
🥈
4
▀▀
2d 8h 46m
7
▀▀
t1b00
🥉
2
4d 5h 38m
4
MariemBaccari
2
6d 11h 51m
1
onsriahi14
2
5d 5h 47m
1
Tyratox
1
3d 10h 1m
3
arnauds5
1
9h 6m
0
1florentin
1
6d 20h 7m
0
sgueissa
1
17d 23h 19m
▀▀
4
ljankoschek
1
7h 42m
0
simone-kalbermatter
1
16d 1h 26m
▀▀
9
▀▀
Kaz-ookid
1
2d 5h 33m
1
⚡️ Pull request stats

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed for 'PoP - PoPCHA-Web-Client'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be1-Go'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Be2-Scala'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe1-Web'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed for 'PoP - Fe2-Android'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

Copy link
Collaborator

@sgueissa sgueissa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm and my bad to not have seen this error at the last review

Copy link
Contributor

@K1li4nL K1li4nL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully this time we got it right, lgtm !

@DanielTavaresA DanielTavaresA added this pull request to the merge queue Apr 16, 2024
Merged via the queue into master with commit d1598fa Apr 16, 2024
19 checks passed
@DanielTavaresA DanielTavaresA deleted the work-protocol-fix-rumor-message-type branch April 16, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants