fix(moonshine.rn/android): consume Moonshine 0.1.5 and lower minSdk to 26 - #473
Closed
petewarden wants to merge 1 commit into
Closed
fix(moonshine.rn/android): consume Moonshine 0.1.5 and lower minSdk to 26#473petewarden wants to merge 1 commit into
petewarden wants to merge 1 commit into
Conversation
Repository owner
deleted a comment from
abretonc7s
Aug 23, 2026
…o 26 Addresses deeeed#425. Maven consumers can use API 26 once moonshine-voice 0.1.5 is published: intent matching uses the public EmbeddingModel API, and per-line speakerId is derived from speakerSpans. iOS stays on v0.0.59. Co-authored-by: Cursor <cursoragent@cursor.com>
petewarden
force-pushed
the
fix/moonshine-rn-android-minsdk-26
branch
from
August 25, 2026 00:35
f633712 to
92804d8
Compare
petewarden
marked this pull request as ready for review
August 25, 2026 00:36
|
Owner
|
Thanks for putting this together, Pete, and for shipping Moonshine 0.1.5. That upstream release unblocked us. We landed the wrapper update separately in #486. It includes minSdk 26, completed-line speaker revisions, intent matching fixes and tests, and an isolated ONNX Runtime so Moonshine can load alongside Sherpa. This is now published as @siteed/moonshine.rn 0.4.1. I'll close this PR as superseded. Thanks again for helping us get there. |
Author
|
That's great to hear, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Addresses #425. Credit to #435 for proving the native libraries load at API 26 and documenting why a Maven bump to 0.1.3 did not compile.
ai.moonshine:moonshine-voice:0.1.5is now on Maven Central (release). That AAR declaresminSdkVersion="26"and exposes a publicEmbeddingModelplusTranscriptLine.speakerSpans, so this wrapper can keep its existing JS intent and speaker fields without adoptingAgentFlow.What changed:
0.0.59→0.1.5; wrapper minSdk floor 35 → 26addAudioToStream/loadTranscriberFromMemoryupdated to the current JNI signaturesEmbeddingModel(register phrases, cosine match). JScreateIntentRecognizer/processUtteranceunchangedhasSpeakerId/speakerId/speakerIndexderived fromspeakerSpans(longest-duration span; first span on a tie)moonshineCommitleft at v0.0.59Checked against the published 0.1.5 AAR:
EmbeddingModeland embedding JNI methods are public;moonshineAddAudioToStreamis the 5-arg form;loadTranscriberFromMemorytakes the optional spelling buffer;TranscriptLinehasspeakerSpansand no per-linehasSpeakerId.libmoonshine.sostill importsOrtGetApiBase@VERS_1.23.2, so the Sherpa coexistence note stays.Test plan
ai.moonshine:moonshine-voice:0.1.5is on Maven Centralyarn workspace @siteed/moonshine.rn testandtypecheckSITEED_MOONSHINE_ANDROID_USE_MAVEN=1), withouttools:overrideLibraryminSdkVersion: 26identifySpeakerson an API 26 emulator