Add container orchestrator environment variable #43
Conversation
bd-g
force-pushed
the
brent-george/container-orchestrator-id
branch
from
ea97f10
to
7c8691b
Compare
bd-g
changed the title
| @@ -9,6 +9,7 @@ The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.1.0/), | |||
| ### Added | |||
|
|
|||
| - Automatic model management on AWS now supports model removal. See the `engine.modelManager.models.remove` section in the `values.yaml` file for details. | |||
| - Container orchestrator environment variable added to improve support. | |||
There was a problem hiding this comment.
Worth calling out the 3 supported values, since it's a small finite set and we could potentially add/change it in the future?
There was a problem hiding this comment.
It's not necessarily intended to be change or configured - I don't think it needs to be called out.
Also, the cardinality will increase, as the Helm value will change for each version (but the prefix will stay the same).
| @@ -14,6 +14,7 @@ services: | |||
| # Make sure you `export` your self-hosted API key secret in your local environment | |||
| environment: | |||
| DEEPGRAM_API_KEY: "${DEEPGRAM_API_KEY}" | |||
| DEEPGRAM_DEPLOYMENT_ORCHESTRATOR: "docker-compose" | |||
There was a problem hiding this comment.
Any way to make this a static variable or enum of some type, or is hard-coding the same string multiple times the best option on these?
There was a problem hiding this comment.
I wasn't previously aware, which is why there is duplication in other places, but your question prompted me to go looking, and I found Docker Compose extension fields. Let me see if they're also compatible with Podman.
There was a problem hiding this comment.
The Compose protocol is fairly limited. I was able to reduce the duplication of the API key and the common orchestrator variable. I tried to do the same for the release tag on each image, but I can edit only a subsection of a field.
It's also not supported by podman-compose right now, so can only use this for the Docker Compose templates.
Proposed changes
Add an environment variable to container launch templates to enable more detailed support for self-hosted deployments.
Types of changes
Checklist