Skip to content

Commit

Permalink
fix: fix format options (#2353)
Browse files Browse the repository at this point in the history
It appears that decimal and integer format options weren't correctly
passing through so the chart was not receiving updates.
  • Loading branch information
jnumainville authored Jan 29, 2025
1 parent d1e345a commit 3869b50
Showing 1 changed file with 10 additions and 7 deletions.
17 changes: 10 additions & 7 deletions packages/chart/src/Chart.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ const log = Log.module('Chart');

type ChartSettings = ColumnFormatSettings &
DateTimeFormatSettings & {
decimalFormatOptions?: DecimalColumnFormatterOptions;
integerFormatOptions?: IntegerColumnFormatterOptions;
defaultDecimalFormatOptions?: DecimalColumnFormatterOptions;
defaultIntegerFormatOptions?: IntegerColumnFormatterOptions;
webgl?: boolean;
};

Expand Down Expand Up @@ -651,18 +651,21 @@ class Chart extends Component<ChartProps, ChartState> {
const columnFormats = FormatterUtils.getColumnFormats(settings);
const dateTimeFormatterOptions =
FormatterUtils.getDateTimeFormatterOptions(settings);
const { decimalFormatOptions = {}, integerFormatOptions = {} } = settings;
const {
defaultDecimalFormatOptions = {},
defaultIntegerFormatOptions = {},
} = settings;

if (
!deepEqual(this.columnFormats, columnFormats) ||
!deepEqual(this.dateTimeFormatterOptions, dateTimeFormatterOptions) ||
!deepEqual(this.decimalFormatOptions, decimalFormatOptions) ||
!deepEqual(this.integerFormatOptions, integerFormatOptions)
!deepEqual(this.decimalFormatOptions, defaultDecimalFormatOptions) ||
!deepEqual(this.integerFormatOptions, defaultIntegerFormatOptions)
) {
this.columnFormats = FormatterUtils.getColumnFormats(settings);
this.dateTimeFormatterOptions = dateTimeFormatterOptions;
this.decimalFormatOptions = decimalFormatOptions;
this.integerFormatOptions = integerFormatOptions;
this.decimalFormatOptions = defaultDecimalFormatOptions;
this.integerFormatOptions = defaultIntegerFormatOptions;
this.updateFormatter();
}

Expand Down

0 comments on commit 3869b50

Please sign in to comment.