Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DH-18542: Remove duplicate and invalid ruff quick fixes #2360

Merged
merged 4 commits into from
Feb 7, 2025

Conversation

mattrunyon
Copy link
Collaborator

Should remove the invalid quick fixes to disable syntax errors (wouldn't that be nice if you could do that)

Also if there is a duplicate code detected (usually only if you have a selection and use the light bulb instead of the hover quick fix link in the modal), then the "diasble RULE for file" should only appear once. There should also be "disable RULE for line X" and "disable RULE for line Y" instead of just "for line".

@mattrunyon mattrunyon requested a review from bmingles February 6, 2025 19:27
@mattrunyon mattrunyon self-assigned this Feb 6, 2025
Copy link

codecov bot commented Feb 6, 2025

Codecov Report

Attention: Patch coverage is 0% with 20 lines in your changes missing coverage. Please review.

Project coverage is 46.72%. Comparing base (9d49873) to head (7efe340).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
packages/console/src/monaco/MonacoProviders.tsx 0.00% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2360      +/-   ##
==========================================
- Coverage   46.75%   46.72%   -0.04%     
==========================================
  Files         710      710              
  Lines       39116    39143      +27     
  Branches     9775     9787      +12     
==========================================
  Hits        18289    18289              
- Misses      20816    20843      +27     
  Partials       11       11              
Flag Coverage Δ
unit 46.72% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@mattrunyon mattrunyon requested a review from bmingles February 7, 2025 17:39
Copy link
Contributor

@bmingles bmingles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Tested the 2 scenarios described in original issue.

@mattrunyon mattrunyon enabled auto-merge (squash) February 7, 2025 17:54
@mattrunyon mattrunyon merged commit f8c0e18 into deephaven:main Feb 7, 2025
11 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Feb 7, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants