-
Notifications
You must be signed in to change notification settings - Fork 33
feat: DH-13515: Expandable columns support #2537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #2537 +/- ##
==========================================
+ Coverage 44.56% 44.94% +0.38%
==========================================
Files 764 765 +1
Lines 42821 42915 +94
Branches 10971 10793 -178
==========================================
+ Hits 19084 19290 +206
+ Misses 23726 23612 -114
- Partials 11 13 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7a10db3
to
2dc827a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good overall. A few small things/suggestions.
ExpandableColumnGridModel
interface for models with expandable columnsColumnHeaderGroup
andIrisGridCellRendererUtils
from@deephaven/iris-grid
IrisGrid
methods to expand/collapse columnsIrisGrid
IrisGridMetricCalculator
now stores user column widths by nameparseColumnHeaderGroups
inIrisGridUtils
has an optional argument allowing to preserve the correct header group classIrisGrid
context menu showsExpand All
andCollapse All
if supported in the model