Skip to content

Binary Search for Best Atom Number in Efficiency Test #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

SchrodingersCattt
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented May 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.37%. Comparing base (142c94a) to head (8e30bbe).
Report is 22 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #262   +/-   ##
=======================================
  Coverage   64.37%   64.37%           
=======================================
  Files          33       33           
  Lines        1457     1457           
  Branches      170      170           
=======================================
  Hits          938      938           
  Misses        482      482           
  Partials       37       37           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@caic99 caic99 requested a review from Copilot May 7, 2025 03:47
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR enhances the inference efficiency calculation by introducing a binary search algorithm to determine the maximum safe scaling factor before an out-of-memory (OOM) error occurs during energy/force computations. Key changes include the addition of the find_maximum_scaling function, the introduction of a new "binary_search" mode in the inference functions, and a stub file (binary_search.py) indicating a pending rename.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
lambench/tasks/calculator/inference_efficiency/inference_efficiency.py Adds binary search-based scaling and mode parameter updates for improved performance monitoring
lambench/tasks/calculator/inference_efficiency/binary_search.py Introduces a stub file with a TODO indicating a planned file rename
Comments suppressed due to low confidence (1)

lambench/tasks/calculator/inference_efficiency/binary_search.py:1

  • [nitpick] The binary_search.py file currently only includes a placeholder comment. Consider renaming the file to more clearly indicate its purpose (e.g., 'scaling_binary_search.py') once its functionality is defined.
## TODO: RENAME...

@anyangml anyangml closed this May 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants