Skip to content

Feat: add natom upper limit for binary search #268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 10, 2025

Conversation

anyangml
Copy link
Collaborator

This is a follow-up update for #264 , and we find a default value of 850 is more suitable for V100.

@anyangml anyangml requested a review from caic99 May 10, 2025 11:01
Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.99%. Comparing base (c7e4b9c) to head (c231a3c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #268   +/-   ##
=======================================
  Coverage   65.99%   65.99%           
=======================================
  Files          35       35           
  Lines        1538     1538           
  Branches      182      182           
=======================================
  Hits         1015     1015           
  Misses        485      485           
  Partials       38       38           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@anyangml anyangml merged commit 7b4c75b into main May 10, 2025
4 checks passed
@anyangml anyangml deleted the fix/parameterize-max-atom-in-efficiency branch May 10, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant