-
Notifications
You must be signed in to change notification settings - Fork 33
feat: When using streaming_generator return final pipeline result as a final streaming chunk
#162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
1c53eb9 to
6821963
Compare
…eline-result-streaming
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sjrl I like the idea of the on_pipeline_end callback!
I've left some comments.
About tests: since now the on_pipeline_end callback is optional (which is good IMHO), why changing all the existing tests? Maybe we could revert this and add some specific tests with specific behaviours of that callback. WDYT?
Sure happy to revert! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice! 🚀
Would also ask if you can update the docs page about Open WebUI integration adding also info about this new callback. Would be great if you can also add the video (in gif) format into assets folder, showing it just after an example.
You can check out the docs contributing guide to run docs website locally (for development) and then deploy it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
Related Issues
streaming_generatorto also return the Pipeline result #146Changes
on_pipeline_endcallback tostreaming_generatorandasync_streaming_generator. This callback is called on the final result returned to the pipeline allowing us to forward the final result of the pipeline to OpenWebUI via aStreamingChunkdefault_on_pipeline_endto serve as a default callback users can provide tostreaming_generatorandasync_streaming_generatorExample
I added the function
to add a references section after the chat with website agent was finished
Screen.Recording.2025-10-10.at.10.44.59.mov