feat: support structured outputs in LlamaStackChatGenerator
#2535
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
type:documentation
anakin87
approved these changes
Nov 20, 2025
Member
anakin87
left a comment
anakin87
left a comment
There was a problem hiding this comment.
I just left two minor comments
integrations/llama_stack/tests/test_llama_stack_chat_generator.py
Outdated
Show resolved
Hide resolved
Comment on lines
+23
to
+25
| @pytest.fixture | ||
| def calendar_event_model(): | ||
| return CalendarEvent |
Member
There was a problem hiding this comment.
nit: in this case, I don't see particular advantages in defining a fixture
Contributor
Author
There was a problem hiding this comment.
The model is used twice in tests. Might be helpful in future or should I remove the fixture?
Co-authored-by: Stefano Fiorucci <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Proposed Changes:
How did you test it?
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:.