Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The updated docs for Ragas-Haystack Integration #297

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

The updated docs for Ragas-Haystack Integration #297

wants to merge 2 commits into from

Conversation

sahusiddharth
Copy link
Contributor

@sahusiddharth sahusiddharth requested a review from a team as a code owner January 28, 2025 19:12
This was referenced Jan 28, 2025
Merged
Merged
@anakin87 anakin87 requested a review from julian-risch January 29, 2025 09:22
jjmachan pushed a commit to explodinggradients/ragas that referenced this pull request Jan 30, 2025
@sahusiddharth
Adding tutorial for Haystack Integration (#1887)
9a7c118 
Integration:
- deepset-ai/haystack-core-integrations#1312

Docs:
- deepset-ai/haystack-integrations#297
bilgeyucel
bilgeyucel reviewed Jan 31, 2025
View reviewed changes
integrations/ragas.md Outdated Show resolved Hide resolved
integrations/ragas.md
Comment on lines +146 to +151
llm = ChatOpenAI(model="gpt-4o-mini")
evaluator_llm = LangchainLLMWrapper(llm)

ragas_evaluator = RagasEvaluator(
ragas_metrics=[AnswerRelevancy(), ContextPrecision(), Faithfulness()],
evaluator_llm=evaluator_llm,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code snippet should be updated with Haystack code

integrations/ragas.md
Comment on lines +327 to +336
evaluation_dataset = EvaluationDataset.from_list(evals_list)

llm = ChatOpenAI(model="gpt-4o-mini")
evaluator_llm = LangchainLLMWrapper(llm)

result = evaluate(
dataset=evaluation_dataset,
metrics=[AnswerRelevancy(), ContextPrecision(), Faithfulness()],
llm=evaluator_llm,
)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This part as well

@sahusiddharth @bilgeyucel
better_table_representation
30c6fd8 
Co-authored-by: Bilge Yücel <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bilgeyucel bilgeyucel bilgeyucel left review comments

@julian-risch julian-risch Awaiting requested review from julian-risch

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sahusiddharth @bilgeyucel