fix: Fix variable extraction in Jinja2 templates returning set variables #10093
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
github-actions
bot
added
topic:tests
type:documentation
Contributor
Author
|
Closing in favor of a new PR to pin jinja2 after an offline discussion |
Contributor
Author
|
Reopening since we found that pinning jinja2 to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
PromptBuilderincorrectly marks internally set Jinja2 variables as required inputs when using `required_variables='*' #9916Proposed Changes:
While investigating #9916 I found this open issue pallets/jinja#2069 in the Jinja2 library which is the cause of our issue.
I've developed a partial workaround by introducing the utility method
_collect_assigned_variables. The work around is partial because it does not exhaustively identify all types of assignment. It only covers regular assignment, list and tuple assignments.I wonder if it would be better to hard-pin
jinja2<=3.15to completely avoid this issue.How did you test it?
Added new tests.
Notes for the reviewer
Checklist
fix:,feat:,build:,chore:,ci:,docs:,style:,refactor:,perf:,test:and added!in case the PR includes breaking changes.