-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add OpenAPIConnector component, improve OpenAPI integration #8808
Open
vblagoje
wants to merge
12
commits into
main
Choose a base branch
from
openapi_component
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+333
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 13196768236Details
💛 - Coveralls |
Why are we introducing the OpenAPIConnector and OpenAPITool
OpenAPIConnectorPros:
Cons:
OpenAPIToolPros:
Cons:
These two new components will replace existing OpenAPIServiceConnector and OpenAPIServiceToFunctions which will be soon deprecated. |
mpangrazzi
reviewed
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good! But should this component be mentioned in docs?
Right @mpangrazzi - I'll create a new doc for it 🙏 |
mpangrazzi
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why:
Enables invocation of REST endpoints specified in an OpenAPI specification. This component will supersede our current
OpenAPIServiceConnector
that needs to work in pair withOpenAPIServiceToFunctions
to achieve what a new future tool - OpenAPITool will do as one tool in our new tooling architecture.What:
OpenAPIConnector
, a new component to invoke REST endpoints from OpenAPI specs.__init__.py
to includeOpenAPIConnector
in the exports.OpenAPIConnector
to ensure its correctness and reliability.How can it be used:
The
OpenAPIConnector
can be used to perform API operations defined in an OpenAPI specification. Initialize it with an OpenAPI spec URL, file path, or string, and use it to call endpoints:How did you test it:
Tests cover initialization, serialization, deserialization, and execution of operations to ensure component functionality.
Notes for the reviewer:
test_openapi_connector.py
file contains both unit and integration tests; some tests require environment variables likeSERPERDEV_API_KEY
orGITHUB_TOKEN
to run integration tests, which are conditionally skipped if not present.openapi-llm
and the potential requirements for the environment setup.