Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes Kafka reader and dialer configuration more flexible by externalizing previously hardcoded timeout and buffer size values. The changes allow these parameters to be configured via the YAML configuration file rather than being fixed in the code.
Key changes:
- Replaces hardcoded Kafka dialer timeout (10s) and adds configurable keep-alive setting
- Makes Kafka reader buffer sizes (MinBytes, MaxBytes) and MaxWait timeout configurable
- Adds logging to track the configured Kafka reader parameters at startup
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| internal/config.go | Adds five new configuration fields for Kafka reader and dialer settings |
| internal/kafka.go | Updates dialer and reader initialization to use config values instead of hardcoded constants; adds logging for configuration visibility |
| banjax-config.yaml | Defines default values for the new Kafka configuration parameters |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.