Skip to content

Conversation

@graingert
Copy link

@graingert graingert commented Dec 19, 2016

Fixes #24.

"devDependencies": {
"assert": "1.1.1",
"mocha": "1.18.2",
"node-util": "0.0.1",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't see this used anywhere

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in the tests

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@graingert
Copy link
Author

This should be considered wip until there's a babel ES5 build

@graingert
Copy link
Author

@defunctzombie I've come up with a slightly nicer way of doing it over at: https://github.com/graingert/browser-libs-node/blob/master/webpack.config.babel.js

This automatically builds a browser safe url module.

@defunctzombie
Copy link
Owner

@graingert Does that mean this PR is ready for review or is not relevant?

@mrtbld
Copy link

mrtbld commented Feb 3, 2017

This PR is important because it contains two breaking changes that node v7.x introduced :

  1. need to give slashes: true to url.format() to get protocol-relative URLs (node #11103);
  2. automatic // inclusion for file: URLs (node 336b027).

So thank you for this, @graingert!

But I was wondering what still needs to be done to get this merged ? Can I help ?

@pho3nixf1re
Copy link

I second that. What is the hold up here and is there anything that can help it along?

@ljharb

This comment has been minimized.

@ljharb ljharb marked this pull request as draft January 27, 2021 04:04
@graingert

This comment has been minimized.

@ljharb ljharb marked this pull request as ready for review January 27, 2021 16:12
This was referenced Jan 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Update to newer version

5 participants