Adding week 1 assignment by szhan223 · Pull Request #2 · delfu/bootcamp

szhan223 · 2021-08-02T17:21:23Z

No description provided.

delfu · 2021-08-02T17:24:25Z

1/assignment-week1.py

+else:
+    pass
+
+#try:


always remove unused code

delfu · 2021-08-02T17:25:36Z

1/assignment-week1.py

+needle = 0
+
+# Check whether the first two inputs are numbers and the last input is a sign
+try:


note: lets learn how to use functions to organize code

we dont need to check for validity. for all assignments we'll assume well formed inputs

delfu · 2021-08-02T17:26:10Z

1/assignment-week1.py

+print ("Intern - Shu Wei")
+print ("")
+
+eArray = list(map(str, input("Please enter your input with spaces between them: ").split()))


no need to call str your input split will already be strings

in python you probably dont need to call list. there are only a few cases you need to call list after a map. we might cover that later

delfu · 2021-08-02T17:26:58Z

1/assignment-week1.py

+eArray = list(map(str, input("Please enter your input with spaces between them: ").split()))
+
+#Definitions
+aCount = (len(eArray))


outer parens is useless

delfu · 2021-08-02T17:27:19Z

1/assignment-week1.py

+
+#Definitions
+aCount = (len(eArray))
+fCount = 3


you need more descriptive variable names.

delfu · 2021-08-02T17:34:34Z

1/assignment-week1.py

+            checkN = int(eArray[CheckNCount-1])
+        except ValueError:
+            print ("Please make sure that the input #", CheckNCount, "is a number")
+            exit()


exit are extremely bad practice. avoid at all cost

What should I use instead to make it stop running?

This whole thing should be in a function and you can return from the function. Or if you're expecting the validation to work, you can just throw an error and let the program crash

delfu · 2021-08-02T17:34:52Z

1/assignment-week1.py

+            exit()
+        CheckNCount = CheckNCount + 2
+else:
+    pass


an else with pass is useless, you can remove both

delfu · 2021-08-02T17:36:08Z

1/assignment-week1.py

+else:
+    pass
+
+if aCount >= 3:


i see what you're doing. this is not good. Your code will only be able to handle 2 operations. What if you need to handle > 2 ? Part 2 of the assignment was hoping you'd arrive at a generic solution

I coded it a way that it can handle n operations. What's stopping it from running more than 2 operations?

delfu · 2021-08-02T17:37:25Z

1/assignment-week1.py

+#    exit()
+
+# Calculation
+import operator


usually, in almost all languages, you'd import at the beginning. just a best of practice. Python lets you do it wherever, and there are cases where you'd have it inside some function but usually, imports at the top

by the way, I have no idea what import does. I was trying to find a way to convert the text (+,-,*,/) into operations and this was one of the solution.

delfu · 2021-08-02T17:38:38Z

1/assignment-week1.py

+    "/" : operator.truediv,
+}
+
+result1 = ops[eArray[fCount-1]](int(eArray[0]), int(eArray[1]))


what makes aCount <= 4 special? you can totally fold this line into the while loop and avoid the if/else all together

the problem that I saw is that in the array, item 1 and 2 are number, then afterwards, the order is even = number, odd = operator. I split the calculation in two parts because of this. It was originally <= 3, but for some reasons it doesn't work, and <=4 works.

szhan223

Additional comments

szhan223 · 2021-08-02T17:56:13Z

1/assignment-week1.py

+aCount = (len(eArray))
+fCount = 3
+nCount = 4
+needle = 0


list(map(str, input("Please enter your input with spaces between them: ").split()))
Yes and I changed int to str :P

szhan223 · 2021-08-02T17:57:11Z

1/assignment-week1.py

+    exit()
+
+if aCount > 3:
+    CheckNCount = 4


check n count is just to check whether numbers are inputted at places where numbers are "allowed"

szhan223 · 2021-08-02T17:57:37Z

1/assignment-week1.py

+    exit()
+
+if aCount > 3:
+    CheckNCount = 4


same thing, check s count is to check whether the operators are inputted at places where operators are allowed

szhan223 · 2021-08-02T17:58:58Z

1/assignment-week1.py

+
+if aCount > 3:
+    CheckNCount = 4
+    while (CheckNCount <= aCount):


Originally, I tried to do it with "for" via:
checkNCount = 4, checkNCount < aCount, checkNCount++, but it didn't work

szhan223 · 2021-08-02T17:59:29Z

1/assignment-week1.py

+    CheckNCount = 4
+    while (CheckNCount <= aCount):
+        try:
+            checkN = int(eArray[CheckNCount-1])


oh so the conversion stays?

szhan223 · 2021-08-02T18:02:05Z

1/assignment-week1.py

+#    exit()
+
+# Calculation
+import operator


by the way, I have no idea what import does. I was trying to find a way to convert the text (+,-,*,/) into operations and this was one of the solution.

delfu

hangman is pretty good. decent structure,

you should enclose most of the code into a function and at the top level just call that function. But this will cause issues with box but it just means your pattern with box is not great (i left comments)

delfu · 2021-08-03T15:27:31Z

1/hangman.py

@@ -0,0 +1,45 @@
+# Problem: the game is currently case-sensitive. A != a
+import getpass


whats getpass?

delfu · 2021-08-03T15:28:15Z

1/hangman.py

+import getpass
+
+# Split the keyword into characters and put them into an array
+def split(keyword):


usually there's no need to split a string into chars. it's already essentially a array of chars

if anything i think list(keyword) will return an array of chars

delfu · 2021-08-03T15:28:55Z

1/hangman.py

+
+# Identify the number of guesses allowed
+def minimum(answer):
+    if len(answer) < 5:


the whole thing can be max(len(answer) + 2, 5)

delfu · 2021-08-03T15:30:43Z

1/hangman.py

+def check_answer(guess):
+    for index, letter in enumerate(answer):
+        if letter == guess:
+            box[index] = guess


ok this works but is a pattern we want to avoid.

either pass in box as an argument or dont use box at all. The reason is your function is now accessing a variable that's outside its scope and can easily create bugs

delfu · 2021-08-03T15:31:42Z

1/hangman.py

+# Ask P1 to input a string for P2 to guess
+keyword = getpass.getpass("Player 1: Please enter the word you want Player 2 to guess: ")
+answer = split(keyword)
+print ("Player 2: There are ",len(answer)," characters you need to guess")


use + instead of , . i think , prints extra spacing and looks weird

delfu · 2021-08-03T15:34:10Z

1/hangman.py

+
+# Create a box to showcase P2 the empty places
+box = []
+while len(box) < len(answer):


you can create box like so box = ["_" for i in range(len(answer))]

this means, you are creating box to be an array and you're initializing its values to be "_" for each position in a range of 0 to length of answer.

delfu · 2021-08-03T15:35:09Z

1/hangman.py

+        print ("Player 2 wins! The answer is: ", " ".join(answer))
+        quit()
+    else:
+        number_of_guesses_left = number_of_guesses_left - 1


you can do number_of_guesses_left -= 1 does the same thing

delfu · 2021-08-03T15:36:43Z

1/hangman.py

+        quit()
+    else:
+        number_of_guesses_left = number_of_guesses_left - 1
+else:


avoid using else with a while. it's a python only thing.

instead just do a check for if number_of_gueses_left <= 0 and player dies

Adding week 1 assignment

39f63fd

delfu reviewed Aug 2, 2021

View reviewed changes

szhan223 commented Aug 2, 2021

View reviewed changes

szhan223 added 2 commits August 3, 2021 08:31

Adding another file

921871d

added the hangman file

54c6b7b

delfu reviewed Aug 3, 2021

View reviewed changes

+              else:
+                  pass
+              #try:

		@@ -0,0 +1,45 @@
		# Problem: the game is currently case-sensitive. A != a
		import getpass

Conversation

szhan223 commented Aug 2, 2021

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

szhan223 left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

delfu left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!