Skip to content

Commit

Permalink
Not include baseConvertedDeltaVersion in iceberg table property when …
Browse files Browse the repository at this point in the history
…flag is off (#3877)

<!--
Thanks for sending a pull request!  Here are some tips for you:
1. If this is your first time, please read our contributor guidelines:
https://github.com/delta-io/delta/blob/master/CONTRIBUTING.md
2. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP]
Your PR title ...'.
  3. Be sure to keep the PR description updated to reflect all changes.
  4. Please write your PR title to summarize what this PR proposes.
5. If possible, provide a concise example to reproduce the issue for a
faster review.
6. If applicable, include the corresponding issue number in the PR title
and link it in the body.
-->

#### Which Delta project/connector is this regarding?
<!--
Please add the component selected below to the beginning of the pull
request title
For example: [Spark] Title of my pull request
-->

- [x] Spark
- [ ] Standalone
- [ ] Flink
- [ ] Kernel
- [ ] Other (fill in here)

## Description

Not include baseConvertedDeltaVersion in iceberg table property when
flag is off

## How was this patch tested?

manual test

## Does this PR introduce _any_ user-facing changes?

<!--
If yes, please clarify the previous behavior and the change this PR
proposes - provide the console output, description and/or an example to
show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change
compared to the released Delta Lake versions or within the unreleased
branches such as master.
If no, write 'No'.
-->
  • Loading branch information
lzlfred authored Nov 15, 2024
1 parent a94e84e commit 6ff1cbf
Showing 1 changed file with 7 additions and 5 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -350,11 +350,13 @@ class IcebergConversionTransaction(
.set(IcebergConverter.DELTA_TIMESTAMP_PROPERTY, postCommitSnapshot.timestamp.toString)
.set(IcebergConstants.ICEBERG_NAME_MAPPING_PROPERTY, nameMapping)

if (spark.sessionState.conf.getConf(
DeltaSQLConf.DELTA_UNIFORM_ICEBERG_INCLUDE_BASE_CONVERTED_VERSION)) {
lastConvertedDeltaVersion.foreach { v =>
updateTxn = updateTxn.set(IcebergConverter.BASE_DELTA_VERSION_PROPERTY, v.toString)
}
val includeBaseVersion = spark.sessionState.conf.getConf(
DeltaSQLConf.DELTA_UNIFORM_ICEBERG_INCLUDE_BASE_CONVERTED_VERSION)
updateTxn = lastConvertedDeltaVersion match {
case Some(v) if includeBaseVersion =>
updateTxn.set(IcebergConverter.BASE_DELTA_VERSION_PROPERTY, v.toString)
case _ =>
updateTxn.remove(IcebergConverter.BASE_DELTA_VERSION_PROPERTY)
}
updateTxn.commit()

Expand Down

0 comments on commit 6ff1cbf

Please sign in to comment.