MISP: Add new parameter to define benign tag ids

[nikstuckenbrock]

Status

• In Progress
• Ready
• In Hold - (Reason for hold)

Description

Added a new parameter to the MISP integration to define tags that should be recognized as benign.

Must have

• Tests
• Documentation

[content-bot]

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @israelpoli will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

[content-bot]

Hi @nikstuckenbrock, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

[israelpoli]

Thank you for your contribution, It looks great 💪

I see that the unit tests are failing due to an argument mismatch in the test_get_score function could you please fix that?

Additionally, if you could update the Docker as well.

thanks 🙏

[nikstuckenbrock]

Hi @israelpoli,

thanks for your feedback. Updated the image and fixed the test.

[nikstuckenbrock]

There seems to a problem with the mock object for the pymisp package since the package update. I'll try to fix it.

[nikstuckenbrock]

Hi @israelpoli,

fixed it. Feel free to recheck if you've got time.

[israelpoli]

Hi @nikstuckenbrock
I’m a bit delayed with the review due to a workload
I hope to go over it again later today
I apologize for the delay
Thank you

[israelpoli]

Good job 💪
I am taking it to the next level hoping to merge to master soon

Thank you

[github-actions]

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.