Fix use of subtree parameter in plot_tree and get_mask#188
Open
tonywong94 wants to merge 4 commits intodendrograms:mainfrom
Open
Fix use of subtree parameter in plot_tree and get_mask#188tonywong94 wants to merge 4 commits intodendrograms:mainfrom
tonywong94 wants to merge 4 commits intodendrograms:mainfrom
Conversation
…t was deprecated since astropy 3.0 now raises a ValueError)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change seems needed to allow custom coloring of the dendrogram subtrees. My main use case is using different colors for trunks, branches, and leaves, but I also use subtree=False to color the structures according to a property like line width or virial parameter.
(This is from a previous pull request that got corrupted, so I have cleaned it up.)