Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(compile): ensure compiled main module path exists #26203

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

littledivy
Copy link
Member

Fixes #26175

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems too hacky of a fix because it only fixes this for the main module's directory and not any modules found in sub directories. For example, if the main module imports a sub directory's file and then the sub directory's file does the code in the issue then the error will still occur.

Either we should update the file system implementation to handle this, shouldn't fix this as by design, or we should extract the module contents to a temporary folder instead of reading from the executable.

lucacasonato
lucacasonato previously approved these changes Oct 21, 2024
@lucacasonato lucacasonato dismissed their stale review October 21, 2024 09:21

just saw david's review

@bartlomieju
Copy link
Member

Is this PR still relevant after recent rewrites @dsherret did to deno compile?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno compile crash when try chdir
4 participants