perf(ext/http): save event loop tick for sync responses #26357

littledivy · 2024-10-17T17:10:18Z

main under heavy load:

[    13.448] op_http_try_wait                                   : Dispatched Fast
[    13.448] op_http_try_wait                                   : Completed Fast
[    13.448] op_http_try_wait                                   : Dispatched Fast
[    13.448] op_http_try_wait                                   : Completed Fast
[    13.449] op_http_wait                                       : Dispatched Async
[    13.449] op_http_set_response_header                        : Dispatched Fast
[    13.449] op_http_set_response_header                        : Completed Fast
[    13.449] op_http_set_response_body_text                     : Dispatched Fast
[    13.449] op_http_set_response_body_text                     : Completed Fast
[    13.449] op_http_set_response_header                        : Dispatched Fast
[    13.449] op_http_set_response_header                        : Completed Fast
[    13.449] op_http_set_response_body_text                     : Dispatched Fast
[    13.449] op_http_set_response_body_text                     : Completed Fast

this patch under heavy load:

[     6.201] op_http_try_wait                                   : Dispatched Fast
[     6.201] op_http_try_wait                                   : Completed Fast
[     6.201] op_http_set_response_header                        : Dispatched Fast
[     6.201] op_http_set_response_header                        : Completed Fast
[     6.201] op_http_set_response_body_text                     : Dispatched Fast
[     6.201] op_http_set_response_body_text                     : Completed Fast
[     6.202] op_http_try_wait                                   : Dispatched Fast
[     6.202] op_http_try_wait                                   : Completed Fast
[     6.202] op_http_set_response_header                        : Dispatched Fast
[     6.202] op_http_set_response_header                        : Completed Fast
[     6.202] op_http_set_response_body_text                     : Dispatched Fast
[     6.202] op_http_set_response_body_text                     : Completed Fast
[     6.202] op_http_try_wait                                   : Dispatched Fast
[     6.202] op_http_try_wait                                   : Completed Fast

Small bump in throughput on Linux (+3-5k rps)

marvinhagemeister · 2024-10-21T07:49:37Z

ext/http/00_serve.ts

        request,
        new ServeHandlerInfo(innerRequest),
      );

+      if (typeof response === "object" && ReflectHas(response, "then")) {


Should we add a null check here? Calling Reflect.has(null, "then") will throw, but not sure how strict we are in ensuring that the callback cannot return null prior to here.

Suggested change

if (typeof response === "object" && ReflectHas(response, "then")) {

if (response !== null && typeof response === "object" && ReflectHas(response, "then")) {

littledivy added 4 commits October 17, 2024 22:18

perf(ext/http): save event loop tick for sync responses

6d459af

Lint

69b5818

Fix

59bfeee

huh

882ff49

marvinhagemeister reviewed Oct 21, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

perf(ext/http): save event loop tick for sync responses #26357

perf(ext/http): save event loop tick for sync responses #26357

littledivy commented Oct 17, 2024 •

edited

Loading

marvinhagemeister Oct 21, 2024

	if (typeof response === "object" && ReflectHas(response, "then")) {
	if (response !== null && typeof response === "object" && ReflectHas(response, "then")) {

perf(ext/http): save event loop tick for sync responses #26357

Are you sure you want to change the base?

perf(ext/http): save event loop tick for sync responses #26357

Conversation

littledivy commented Oct 17, 2024 • edited Loading

marvinhagemeister Oct 21, 2024

Choose a reason for hiding this comment

littledivy commented Oct 17, 2024 •

edited

Loading