-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cli): enable sub-process to run in detached mode #7481
Conversation
Should I introduce this as an unstable feature? |
There are still some issues with windows not properly detaching... it seems like process spawner hangs until child exits even if detached flags are provided. I based my windows code on this part of the rust std: |
@piscisaureus Could you take a look? This doesn't seem to work: |
@Qu4k please rebase the PR and let's try to get it landed for |
I can but this still doesn't work in windows... |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
Has this been abandoned? I don't really use Windows so I can't help, but I feel like it's pretty important to be able to spawn detached child processes. |
Well it's not abandoned but i don't have any way to test on windows so i'm blocked |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions. |
@filipporeds thank you for the PR, but I'm going to close it without a merge. Currently it's most likely that we'll adjust subprocess API as described in #9435 and ability to detach processes will be included in the rewrite. Thanks again! |
The PR is to enable processes started via
Deno.run()
to run in detached mode.This is a continuation of #5836,
Discussion can be found in #5501
TODO: