Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add source maps to graph #149

Merged
merged 4 commits into from
Apr 28, 2022
Merged

Conversation

kitsonk
Copy link
Contributor

@kitsonk kitsonk commented Apr 27, 2022

Closes #146

This adds source maps to the module graph. When adding a module to the graph, it will be checked to see if it references a source map, and if it does, it will add it to the graph. If it is an inline source map, it will be decoded and added as a JSON value. If it is just a reference to a file, the parsed specifier it references will be added to the graph.

This will enable the CLI to be able to utilise upstream source maps when running code and re-mapping code points.

@kitsonk kitsonk requested review from dsherret and bartlomieju April 27, 2022 04:26
Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, no comments

Copy link
Member

@dsherret dsherret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Just one small potential issue.

@kitsonk kitsonk merged commit 2b8b979 into denoland:main Apr 28, 2022
@kitsonk kitsonk deleted the kitsonk/issue146 branch April 28, 2022 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Identify source map URLs in modules
3 participants